remove the older protocol implementation #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpryan
requested changes
Nov 21, 2023
| # https://github.com/dart-lang/test/blob/master/pkgs/test/doc/configuration.md. | ||
|
|
||
| # Some of the project_creator_test.dart tests don't like to run in parallel with | ||
| # other tests. |
There was a problem hiding this comment.
Hmm, this might be something we should investigate.
There was a problem hiding this comment.
Probably; I don't think it's necessary a serious underlying issue, and even w/ this the tests finish in ~30 seconds. As you say though, it would be good to investigate, esp. to rule out something serious.
pkgs/dart_services/lib/src/sdk.dart
Outdated
| // <flutter-sdk>/bin/cache/dart-sdk | ||
| final dart = Platform.resolvedExecutable; | ||
| final dartSdk = path.dirname(path.dirname(dart)); | ||
| final flutterSdk = path.dirname(path.dirname(path.dirname(dartSdk))); |
There was a problem hiding this comment.
(nit) We might want to consider making sdkPath a field on the Sdk class. Right now we are caching the value globally, and then the Sdk constructor uses this value to get the Dart executable path back out again.
There was a problem hiding this comment.
👍 - I took a stab at that in this PR
johnpryan
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.