Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate a new 'serverRevision' field for the version response #2775

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

devoncarew
Copy link
Member

  • populate a new serverRevision field for the version response

This can help us know which revision a server is serving. I believe that the cloud K_REVISION env var - when deployed via a github trigger - is the git SHA value.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew merged commit 1f70b2c into main Dec 27, 2023
7 checks passed
@devoncarew devoncarew deleted the revision branch December 27, 2023 18:57
@devoncarew
Copy link
Member Author

Hmm, it looks like it's being populated with dart-service-cloud-run-00638-c9f; I may follow up this PR w/ one that plumbs through the git SHA of the version that was deployed.

@parlough
Copy link
Member

parlough commented Dec 27, 2023

Sounds good! A commit hash does sound like it'd be easier and more useful. It seems Cloud Build has a substitution of the trigger commit hash you could pipe through if we don't already have access to it somewhere else: https://cloud.google.com/build/docs/configuring-builds/substitute-variable-values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants