Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DartPad UI (not frame) to new bootstrap mechanism #3012

Merged
merged 4 commits into from
Jun 27, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions pkgs/dartpad_ui/web/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@
<title>DartPad</title>
<link rel="manifest" href="manifest.json">

<script>
// The value below is injected by flutter build, do not touch.
const serviceWorkerVersion = null;
</script>

<link href="https://fonts.googleapis.com/css2?family=Roboto&family=Roboto+Mono&display=swap" rel="stylesheet">
<link href="codemirror/codemirror.css" rel="stylesheet">
<link href="styles/cm-dartpad-dark.css" rel="stylesheet" media="screen">
Expand Down Expand Up @@ -80,26 +75,11 @@
width: 100%;
}
</style>

<!-- This script adds the flutter initialization JS code -->
<script src="flutter.js" defer></script>
parlough marked this conversation as resolved.
Show resolved Hide resolved
</head>

<body>
<script>
window.addEventListener('load', function (ev) {
// Download main.dart.js
_flutter.loader.loadEntrypoint({
serviceWorker: {
serviceWorkerVersion: serviceWorkerVersion,
},
onEntrypointLoaded: function (engineInitializer) {
engineInitializer.initializeEngine().then(function (appRunner) {
appRunner.runApp();
});
}
});
});
{{flutter_bootstrap_js}}
parlough marked this conversation as resolved.
Show resolved Hide resolved
</script>
</body>

Expand Down
Loading