Stop scrolling to end of console on selection #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
lgtm - thanks!
I wonder if there is any performance difference between a TextField and SelectableText when the amount of text gets large? Esp. as we are appending ~a line of text at a time - I wonder if we'll hit any n^2 issues?
We can keep an eye out for performance issues w/ snippets with lots of output, and perhaps choose to do something like only keep 5k of output at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes it as the text editing controller was triggering the listener when selections were made. We don't use the text field/editing functionality anyway.
Fixes #2931