New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miscellaneous updates to the current_results_ui codebase #125

Closed

devoncarew wants to merge 6 commits into master from updates

Member

devoncarew commented Feb 19, 2022 •

edited

Loading

Various and sundry updates to the current_results_ui/ codease:

use the url_launcher plugin; this lets use remove the dart:html references from the flutter app
use package:flutter_lints for linting; this are the latest best practice lints for flutter. most of the code changes in this commit are mechanical changes performed by dart fix
avoid using package:clippy; this was not migrated to null safety, and there's an API to do what we need in flutter
delete some unused generated protobuf files
migrate current_results_ui/ to null safety; all the changes here are what were suggested by dart migrate

--

I see this in the readme.md:

The repository is based at dart.googlesource.com/dart_ci. It is mirrored to github.com/dart-lang/dart_ci. Do not land pull requests on Github.

If PR won't work here, I can recreate this work as a gerrit CL. However, it would be nice to either take PRs, or, add some brief contributing instructions to the repo to describe how to author changes.

You might consider flipping the system of record for the codebase, as that would allow us to do things like use github actions to validate the code.

devoncarew added 6 commits

February 19, 2022 11:33


          use the url_launcher plugin

d9b8e11


          use package:flutter_lints

46c4132


          move away from using package:clippy

de879e4


          remove unused files

f77beb4


          migrate to null safety

9c6392b


          flutter format

83264ef

devoncarew requested a review from whesse

February 19, 2022 20:14

devoncarew mentioned this pull request

various UI changes; show fetch progress, use animation, ... #126

Closed

whesse suggested changes

View reviewed changes

Contributor

whesse left a comment

LGTM. I've copied this PR over to the Gerrit CL
https://dart-review.googlesource.com/c/dart_ci/+/233780
and added some changes corresponding to my comments.

The resulting CL is deployed to staging, for testing, at
https://dart-ci-staging.firebaseapp.com/current_results

I have filed the question about adding Contributors information,
and/or switching to Github reviews, as a new issue: #127

current_results_ui/pubspec.yaml

@@ @@ -8,7 +8,6 @@ environment: @@
                 sdk: ">=2.9.0 <3.0.0"
               dependencies:
-                clippy: ^1.0.0

Contributor

whesse Feb 21, 2022

The pubspec.lock file is checked in, so generate it with a specified version of Flutter, and commit the changes.

current_results_ui/lib/main.dart

@@ @@ -75,7 +75,7 @@ class Providers extends StatelessWidget { @@
                       child: Builder(
                         // ChangeNotifierProvider.value in a Builder is needed to make
                         // the TabController available for widgets to observe.
-                        builder: (context) => ChangeNotifierProvider<TabController>.value(
+                        builder: (context) => ChangeNotifierProvider<TabController?>.value(
                           value: DefaultTabController.of(context),

Contributor

whesse Feb 21, 2022

I prefer to add ! to the argument, here.

current_results_ui/lib/results.dart

@@ @@ -48,8 +48,8 @@ class ResultsPanel extends StatelessWidget { @@
               class ExpandableResult extends StatefulWidget {
                 final String name;
-                final Map<ChangeInResult, List<Result>> changeGroups;
-                final Counts counts;
+                final Map<ChangeInResult, List<Result>>? changeGroups;

Contributor

whesse Feb 21, 2022

I prefer to make these non-nullable, and add null asserts to the values before constructing.

current_results_ui/lib/results.dart

@@ @@ -60,11 +60,11 @@ class ExpandableResult extends StatefulWidget { @@
               class CountItem {
                 final String text;
-                final Color color;
+                final Color? color;

Contributor

whesse Feb 21, 2022

I prefer to make this non-null.

current_results_ui/lib/results.dart

                 CountItem._(this.text, this.color);
-                factory CountItem(int count, Color color) {
+                factory CountItem(int count, Color? color) {

Contributor

whesse Feb 21, 2022

I prefer to add non-null assertions in lines 80-82.

current_results_ui/lib/results.dart

                         ),
                       ),
                       if (expanded)
-                        for (final change in changeGroups.keys)
+                        for (final change in changeGroups!.keys)

Contributor

whesse Feb 21, 2022

This could be non-nullable, as suggested above.
To remove the null checks on changeGroups[change] below, we would need to iterate over
changeGroups.entries, which is perhaps too ugly.

current_results_ui/lib/results.dart

@@ @@ -250,7 +250,7 @@ class Summary extends StatelessWidget { @@
               }
               class Pill extends StatelessWidget {
-                final Color color;
+                final Color? color;

Contributor

whesse Feb 21, 2022

I prefer non-nullable.

current_results_ui/lib/main.dart

@@ @@ -28,7 +28,7 @@ class CurrentResultsApp extends StatelessWidget { @@
                     ),
                     initialRoute: '/',
                     onGenerateRoute: (RouteSettings settings) {
-                      final parameters = settings.name.substring(1).split('&');
+                      final parameters = settings.name!.substring(1).split('&');
                       final terms = parameters
                           .firstWhere((parameter) => parameter.startsWith('filter='),

Contributor

whesse Feb 21, 2022

In line 49, I had to add ! to WidgetsBinding.instance to avoid an analyzer error with Flutter 2.11.0-0.1.pre

Member Author

devoncarew commented Feb 21, 2022

Thanks for moving this to a gerrit review! I lgtm'd it there.

devoncarew closed this

copybara-service bot pushed a commit that referenced this pull request


          Migrate current_results_ui to null safety.

21f2996

This is a copy of PR #125
by Devon Carew (devoncarew).

Drop web-only packages and use flutter_lints.

Specify the deployment Flutter version in README.md.

Change-Id: Ic81b7910c725b6f0cdb28bea94e3c78489f824f1
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/233780
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: William Hesse <whesse@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment