Fix a couple of crashes I found when testing the migration on a corpus. #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are basically three issues here: - The debug library, which isn't part of the public API, could crash when logging a chunk that wasn't fully initialized. Turned NestingLevel from late back to nullable to fix this. This doesn't affect users. - The null safety migration introduced a crash when formatting blocks inside string interpolation (why would someone do that?!). To fix that, instead of returning null chunks, changed ChunkBuilder to return dummy chunks. They end up getting discarded anyway. - Cascaded index operators always crash. I need to investigate more, but I think this bug may exist in the previous version of dart_style, which is in the SDK. I'll look into that next.
Phew. Good news: The stable SDK looks like it's fine. The null just flows through without causing any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are basically three issues here:
The debug library, which isn't part of the public API, could crash
when logging a chunk that wasn't fully initialized. Turned
NestingLevel from late back to nullable to fix this. This doesn't
affect users.
The null safety migration introduced a crash when formatting blocks
inside string interpolation (why would someone do that?!). To fix
that, instead of returning null chunks, changed ChunkBuilder to
return dummy chunks. They end up getting discarded anyway.
Cascaded index operators always crash. I need to investigate more, but
I think this bug may exist in the previous version of dart_style,
which is in the SDK. I'll look into that next.