Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues on dev in update_tests.dart #1233

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix linter issues on dev in update_tests.dart #1233

merged 1 commit into from
Jun 13, 2023

Conversation

athomas
Copy link
Member

@athomas athomas commented Jun 13, 2023

No description provided.

@athomas athomas marked this pull request as ready for review June 13, 2023 07:55
@athomas
Copy link
Member Author

athomas commented Jun 13, 2023

@munificent dart format still breaks (not sure what to do about this, fixing this would probably break on 2.19):

--- a/lib/src/testing/test_file.dart
+++ b/lib/src/testing/test_file.dart
@@ -14,8 +14,8 @@ final _unicodeEscapePattern = RegExp('[\x0a\x0c\x0d]');
 Future<String> findTestDirectory() async {
   var libraryUri = await Isolate.resolvePackageUri(
       Uri.parse('package:dart_style/src/testing/test_file.dart'));
-  return p.normalize(
-      p.join(p.dirname(libraryUri!.toFilePath()), '../../../test'));
+  return p
+      .normalize(p.join(p.dirname(libraryUri!.toFilePath()), '../../../test'));
 }

@athomas athomas requested a review from munificent June 13, 2023 08:06
Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@athomas athomas merged commit 150917f into main Jun 13, 2023
4 of 5 checks passed
@athomas athomas deleted the linter-dev branch June 13, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants