Add ability to "Crossdartify" the source code #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping :) |
|
Any updates? :) |
|
Sorry, missed this PR. Will take a look. Anton, could you sync to head? The test failure on the dev build has been fixed. |
If there's a crossdart.json file in the input dir (which can be
generated by Crossdart), it will use that file to add links to
crossdart.info in the source code block.
Since now we should support links in the source code section, I removed
`<code>` wrapping tags from it, and also now I HTML escape the source
code, and use triple mustache curly braces (`{{{sourceCode}}}`) to
insert it to the page.
Hopefully, that will simplify developer's life, when they want to look
into the method's implementation.
|
Done! All green now! |
|
Looks good! Looking forward to seeing it on dartdocs.org. |
|
Thank you! I'll start regenerating docs with crossdart integration this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a crossdart.json file in the input dir (which can be generated by Crossdart), it will use that file to add links to crossdart.info in the source code block.
Since now we should support links in the source code section, I removed
<code>wrapping tags from it, and also now I HTML escape the source code, and use triple mustache curly braces ({{{sourceCode}}}) to insert it to the page.Hopefully, that will simplify developer's life, when they want to look into the method's implementation.
Example: https://www.dartdocs.org/documentation/hop/0.30.4+2/hop/runHop.html
/cc @sethladd