pass in url for site #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Directory out; | ||
| Set<LibraryElement> libraries = new Set(); | ||
| HtmlGenerator generator; | ||
|
|
||
| DartDoc(this._rootDir, this._excludes); | ||
| DartDoc(this._rootDir, this._excludes, this._url); |
There was a problem hiding this comment.
Could make it optional, but then would have to check whether to pass it in or not. Don't know which is the better approach here.
There was a problem hiding this comment.
We could say that URL is a property of the backend. From an API perspective, URL really only belongs in HtmlGenerator.
How is this DartDoc class intended to be used? I don't think DartDoc class should have a reference to HtmlGenerator. Instead:
- Create one or more generators, and configure them
- Give the list of generators to DartDoc
Thoughts?
There was a problem hiding this comment.
Yes, the url is for the HtmlGenerator. Like the idea of separation and configuring the generator based on user args. Will refactor next time around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sethladd