New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary EnclosedElement mixin #3736

Merged

srawlins merged 1 commit into dart-lang:main from srawlins:no-enclosed-element

Mar 27, 2024

Member

srawlins commented Mar 27, 2024

And a few related cleanups:

_compareElementRepresentations does not need to be generic.
ContainerMember.definingEnclosingContainer is only used by overrides and tests. In order to reduce confusion about the utility of this, mark it protected and visibleForTesting.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Remove unnecessary EnclosedElement mixin

bb9e44c

srawlins requested a review from kallentu

March 27, 2024 13:06

kallentu approved these changes

View reviewed changes

Member

kallentu left a comment

Nice!

srawlins merged commit bf6080c into dart-lang:main

9 checks passed

srawlins deleted the no-enclosed-element branch

March 27, 2024 21:02

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev dartdoc, http

3b23ffe

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/79c1675..bf6080c):
  bf6080c8  2024-03-27  Sam Rawlins  Remove unnecessary EnclosedElement mixin (dart-lang/dartdoc#3736)
  c5bb9066  2024-03-26  Sam Rawlins  Bump to 8.0.8; fix changelog wrapping (dart-lang/dartdoc#3735)
  4e096f84  2024-03-26  Sam Rawlins  Format parameters better (dart-lang/dartdoc#3731)

http (https://github.com/dart-lang/http/compare/7949d6f..280d361):
  280d361  2024-03-27  Derek Xu  [package:http_profile] Expand README.md (dart-lang/http#1162)
  9fddb1c  2024-03-27  Brian Quinlan  Fix the connectionInfo getter (dart-lang/http#1163)
  9f47439  2024-03-27  Derek Xu  [package:http_profile] Make connectionInfo a top-level field of HttpClientRequestProfile (dart-lang/http#1160)

Change-Id: Ib50584ef7d7914ab262bb01eeb087e44c34e4dc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360240
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet