Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http library should redefine some of the enums from 'dart:io' #18

Closed
DartBot opened this issue Jun 5, 2015 · 3 comments
Closed

http library should redefine some of the enums from 'dart:io' #18

DartBot opened this issue Jun 5, 2015 · 3 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#18746

This issue was originally filed by ovan...@gmail.com


Now that the http library supports both browser and console contexts, libraries intending to use the library to provide requests are unable to use some of the useful enums defined in 'dart:io', (specific to my use case, HttpHeaders and HttpStatus).

It would be useful if the http library could redefine or reexport some of these classes.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/8631949?v=3" align="left" width="48" height="48"hspace="10"> Comment by floitschG


Removed Type-Defect label.
Added Type-Enhancement, Area-Library, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Removed Area-Library label.
Added Area-Pkg, Pkg-Http labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


I don't think these enums add a lot of value compared to the verbosity of using them. The HttpHeaders enum names already encode the names of the headers, and the HTTP response codes are often known better numerically than by their names.


Added NotPlanned label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant