Stop using dart:mirrors. #55
Conversation
| @@ -28,10 +27,7 @@ abstract class Client { | |||
| /// Currently this will create an [IOClient] if `dart:io` is available and | |||
| /// throw an [UnsupportedError] otherwise. In the future, it will create a | |||
| /// [BrowserClient] if `dart:html` is available. | |||
There was a problem hiding this comment.
This comment isn't relevant anymore, since you can't import this library without "dart:io" being available, can you?
There was a problem hiding this comment.
It can now be importable while also being unavailable in the sense that its API just throws UnsupportedErrors.
| @@ -3,37 +3,24 @@ | |||
| // BSD-style license that can be found in the LICENSE file. | |||
|
|
|||
| import 'dart:async'; | |||
| import 'dart:io'; | |||
There was a problem hiding this comment.
Does this mean "package:http/http.dart" can only be imported on the command line VM? If so, isn't that a breaking change?
There was a problem hiding this comment.
As of 1.22, dart:io is importable on all platforms and will just throw UnsupportedErrors at runtime if it's not supported.
There was a problem hiding this comment.
What?! Where was that announced? It's not in the CHANGELOG.
There was a problem hiding this comment.
Is the change to dart:io for 1.22 or 1.23? (I heard it was 1.23.)
There was a problem hiding this comment.
I have a fix out as #58
Closes #1