Migrate http2 to null safety #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iinozemtsev
force-pushed
the
null_safety
branch
2 times, most recently
from
2d47391
to
b4a1059
Compare
iinozemtsev
force-pushed
the
null_safety
branch
from
b4a1059
to
85c49cf
Compare
lrhn
reviewed
Jan 14, 2021
experimental/server.dart
Outdated
| @@ -47,7 +47,7 @@ void handleClient(SecureSocket socket) { | |||
| connection.incomingStreams.listen((ServerTransportStream stream) async { | |||
| dumpInfo('main', 'Got new HTTP/2 stream with id: ${stream.id}'); | |||
|
|
|||
| String path; | |||
| String? path; | |||
| stream.incomingMessages.listen((StreamMessage msg) async { | |||
There was a problem hiding this comment.
Nit: Consider using forEach instead of listen when you don't use the subscription (unless you expect the stream to contain errors, which it doesn't seem like).
lib/src/connection_preface.dart
Outdated
| @@ -42,13 +42,13 @@ const List<int> CONNECTION_PREFACE = [ | |||
| /// connection preface. If an error occurs while reading the connection | |||
| /// preface, the returned stream will have only an error. | |||
| Stream<List<int>> readConnectionPreface(Stream<List<int>> incoming) { | |||
| StreamController<List<int>> result; | |||
| StreamSubscription subscription; | |||
| late StreamController<List<int>> result; | |||
There was a problem hiding this comment.
I'd initialize result = StreamController(); and just set onListen etc. later. Then there is no need for late.
|
Thanks Lasse! That is very helpful |
Analysis exclusions are not needed for these files anymore
natebosch
approved these changes
Jan 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.