Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Peer requests not terminating when the channel closes #52

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Fix Peer requests not terminating when the channel closes #52

merged 3 commits into from
Jun 8, 2020

Commits on May 27, 2020

  1. Fix Peer requests not terminating when the channel closes 

    The `listen()` method of `Peer` never propagates close events from its manager to the `client` field. This causes in-flight requests to never terminate as the clean up handler at https://github.com/dart-lang/json_rpc_2/blob/d589e635d8ccb7cda6a804bd571f88abbabab146/lib/src/client.dart#L65-L72 is never called.
    @jiahaog
    jiahaog committed May 27, 2020
    Configuration menu
    Copy the full SHA
    4718d5f View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Merge branch 'master' into fix-close

    @jiahaog
    jiahaog committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    9938778 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Don't use pedantic in peer

    @jiahaog
    jiahaog committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    c34c8ae View commit details
    Browse the repository at this point in the history