Fix Peer requests not terminating when the channel closes
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahaog
force-pushed
the
fix-close
branch
2 times, most recently
from
2872f62
to
fd4bb81
Compare
The `listen()` method of `Peer` never propagates close events from its manager to the `client` field. This causes in-flight requests to never terminate as the clean up handler at https://github.com/dart-lang/json_rpc_2/blob/d589e635d8ccb7cda6a804bd571f88abbabab146/lib/src/client.dart#L65-L72 is never called.
|
@natebosch Can you help to take a look at this please 🙂 |
natebosch
reviewed
Jun 3, 2020
natebosch
approved these changes
Jun 8, 2020
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 12, 2020
In dart-lang/json_rpc_2#52 the `Peer` class was fixed to behave like a `Client` when the connection is closed with outstanding requests. `package:dds` was previously relying on having the futures never complete to send the `serviceDisappeared` code when the client was closed with outstanding requests. Check also for the `StateError` that would result from outstanding requests and translate them to `serviceDisappeared`. Change-Id: I2d3f186d1d52d34082b7adf5bf962e22df74015b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158220 Auto-Submit: Nate Bosch <nbosch@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
listen()method ofPeernever propagates close events from its manager to theclientfield. This causes in-flight requests to never terminate as the clean up handler here is never called.json_rpc_2/lib/src/client.dart
Lines 65 to 72 in d589e63