-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro bootstrap script expects zero argument constructor #2189
Comments
Yes, looks like that will need to change to just |
Note that this code is also currently being modified, probably want to wait until https://dart-review.googlesource.com/c/sdk/+/239466 lands to change this just to avoid more conflicts |
I'll let you make any changes here. I don't have a dart-sdk set up for contributing right now. Just didn't know if you were aware of this. |
I wasn't, although I am sure it would have come up once we tried to add the functionality to the CFE 👍 . But I can get ahead of things and fix it soon. |
@jakemac53 - where should we track issues related to macros? In the language repo? Here, as an issue in |
I went ahead and moved this to the language repo, as that is where everything is currently tracked. Although this is more of an implementation thing and the change will be in the SDK. So we could create a label there or something? But it might be easier to keep everything in the language repo. |
Yeah, I think once we start productionizing things, we'll probably want an |
That sounds good to me |
Bug:dart-lang/language#2189 Change-Id: I89978d216a906357938ad509e4b0e5e390abe6d5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240420 Auto-Submit: Jake Macdonald <jakemac@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
This should be fixed by https://dart-review.googlesource.com/c/sdk/+/240420 |
(but note that the CFE still doesn't support it) |
@jakemac53 I was experimenting with the macro example on the language repo and ran into an error in the bootstrap script assigning to this map. It seems that there is some support for macro arguments maybe(?), but this made it so I could not experiment with them.
Macro Function()
-->Function
is probably how it has to change.https://github.com/dart-lang/sdk/blob/6d543de174a229597184ee2404b7d53e328d731c/pkg/_fe_analyzer_shared/lib/src/macros/bootstrap.dart#L173
The text was updated successfully, but these errors were encountered: