Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature specification for inline classes #2626

Merged
merged 16 commits into from
Dec 16, 2022
Merged

Add feature specification for inline classes #2626

merged 16 commits into from
Dec 16, 2022

Commits on Nov 29, 2022

  1. Copy views feature spec to inline-class feature spec, change the word… 

    … `view` to `inline`
    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    04e9518 View commit details
    Browse the repository at this point in the history

  2. Create inline class feature specification as a copy of the views spec… 

    …, plus rename
    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    1ee095d View commit details
    Browse the repository at this point in the history

  3. Undo the renaming of view to inline in the views specification

    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    14af5d0 View commit details
    Browse the repository at this point in the history

  4. Review response

    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    343b57a View commit details
    Browse the repository at this point in the history

  5. Review response (comments arriving later)

    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    3fe8469 View commit details
    Browse the repository at this point in the history

  6. Review response

    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d02afc2 View commit details
    Browse the repository at this point in the history

  7. Response to even more review comments

    @eernstg
    eernstg committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    5267617 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Review response. In particular: removed the I.super.foo() syntax

    @eernstg
    eernstg committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    2e0fa60 View commit details
    Browse the repository at this point in the history

  2. Corrected and simplified the treatment of cycles in the Inline-to-Rep… 

    …resentation-type check
    @eernstg
    eernstg committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    7f22ef0 View commit details
    Browse the repository at this point in the history

  3. Improved wording of cyclic dependency rule

    @eernstg
    eernstg committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    2027e77 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Clarified nullability properties of inline types

    @eernstg
    eernstg committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    227bdb2 View commit details
    Browse the repository at this point in the history

  2. Added more commentary about nullability

    @eernstg
    eernstg committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    628a1ae View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Review response, about nullability

    @eernstg
    eernstg committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ce42388 View commit details
    Browse the repository at this point in the history

  2. Review response: Adding error for type variable bounds being ill-form… 

    …ed after erasure
    @eernstg
    eernstg committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    15b5cbf View commit details
    Browse the repository at this point in the history

  3. Review response: Defined "inline erasure" and used it to simplify the… 

    … new error
    @eernstg
    eernstg committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e13bf16 View commit details
    Browse the repository at this point in the history

  4. Update in response to #2710

    @eernstg
    eernstg committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d55f4b3 View commit details
    Browse the repository at this point in the history