Adjust definition of flatten #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is a type variable which is unrelated to future types
|
Visit the preview URL for this PR (updated for commit b272cd5): https://dart-specification--pr2696-specify-flatten-dec2-jxery4vn.web.app (expires Thu, 15 Dec 2022 15:04:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6941ecd630c4f067ff3d02708a45ae0f0a42b88a |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 13, 2022
The definition of flatten was adjusted in dart-lang/language#2696 such that it better preserves the type information when the type of `e` in `await e` is a type variable. This CL changes the test to expect the behavior of the newly specified flatten. The test has been renamed to 'await_flatten_test.dart'. Change-Id: Iaf67a53cd3cd181bcb3eb6e85beca7cc1af4d34a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274682 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust definition of flatten to ensure that
flatten(X) == XwhenXis a type variable which is unrelated to future types. It deletes the case which is explicitly dealing with type variables, and relies on the existing cases where the given type is related toFutureOrorFuture, but adds one thing: TheFutureOrcase is applicable to types that are bounded byFutureOr<S>for someS, not just the ones that areFutureOr<S>, and this includesX extends FutureOr<S>.