Add an enumEntry grammar rule
#3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Apr 2, 2024
|
Thanks! I'll land this and add the |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 3, 2024
An `enumEntry` needs to allow for the keyword `augment` in order to enable augmentation libraries. This CL performs a grammar rule update in Dart.g and Dart.g4, such that this keyword can be included. The corresponding change to the feature specification was performed in dart-lang/language#3688. Change-Id: I6d6a3f09754a76da668dfc84cd20a7df812ecdbd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360642 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature specification includes examples where an
enumvalue has the formaugment <identifier>, but the grammar doesn't allow for the keywordaugmentin that position. This PR adds the missing grammar rule.