Allow non-literal strings in prefer_interpolation_to_compose_strings (

#735) (#832) Allow concatentation of two non-literal strings in `prefer_interpolation_to_compose_strings`. Fixes: #735
dart-lang · Nov 2, 2017 · 7867eef · 7867eef
1 parent caf2e34
commit 7867eef
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/src/rules/prefer_interpolation_to_compose_strings.dart b/lib/src/rules/prefer_interpolation_to_compose_strings.dart
@@ -53,6 +53,12 @@ class _Visitor extends SimpleAstVisitor {
       return;
     }
     if (node.operator.type == TokenType.PLUS) {
+      //OK(#735): str1 + str2
+      if (node.leftOperand is! StringLiteral &&
+          node.rightOperand is! StringLiteral) {
+        return;
+      }
+      //OK: 'foo' + 'bar'
       if (node.leftOperand is StringLiteral &&
           node.rightOperand is StringLiteral) {
         return;

diff --git a/test/rules/prefer_interpolation_to_compose_strings.dart b/test/rules/prefer_interpolation_to_compose_strings.dart
@@ -22,4 +22,7 @@ void main() {
     pad = pad + ' '; // LINT
   }
 
+  var str1 = 'Hello';
+  var str2 = 'World';
+  var str3 = str1 + str2; // OK (#735)
 }