Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wildcard Variables] support for avoid_unused_constructor_parameters #4995

Closed
Tracked by #4969
pq opened this issue Jun 10, 2024 · 1 comment
Closed
Tracked by #4969

[Wildcard Variables] support for avoid_unused_constructor_parameters #4995

pq opened this issue Jun 10, 2024 · 1 comment
Assignees
@pq
Labels
false-positive new-language-feature P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Jun 10, 2024

No description provided.

@pq pq mentioned this issue Jun 10, 2024
Open
@pq pq self-assigned this Jun 10, 2024
@pq pq added new-language-feature P2 A bug or feature request we're likely to work on false-positive labels Jun 10, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 10, 2024
@pq
[wildcards] avoid_unused_constructor_parameters wildcard test
224d19e 
Test to ensure that `avoid_unused_constructor_parameters` doesn't overreport in the presence of an unused wildcard param.

(Note that underscores are ignored pre-wildcards too and this ensures that that behavior is preserved too.)

Fixes: dart-lang/linter#4995

Change-Id: I13ef73eb28cf2501ed292dd3c56c9933a8feefa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370540
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@pq
Copy link
Member Author

pq commented Jun 14, 2024

Fixed w/ dart-lang/sdk@224d19e

@pq pq closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
false-positive new-language-feature P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq