Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag async directory methods #1673

Merged
merged 3 commits into from
Aug 7, 2019
Merged

flag async directory methods #1673

merged 3 commits into from
Aug 7, 2019

Conversation

pq
Copy link
Member

@pq pq commented Aug 7, 2019 •
edited
Loading

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 96.838% when pulling eef56b7 on dir_async into 5b52358 on master.

bwilkerson
bwilkerson approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement, but it might be better to implement the rule by flagging the use of any member foo that returns a Future (or FutureOr) when there is a fooSync that doesn't.

@pq pq merged commit e9765c3 into master Aug 7, 2019
@pq pq deleted the dir_async branch August 7, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avoid_slow_async_io not reported for Directory.exists
4 participants
@pq @coveralls @bwilkerson @googlebot