Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new rule sets in the machine generated rules file #2691

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

parlough
Copy link
Member

@parlough parlough commented Jun 1, 2021

Includes core, recommended, and effective_dart in the machine generated JSON file. I'm heavily open to suggestions on alternative names for these :)

Also fetches the badge info in the main method in-case this tool is run standalone to make sure the sets are retrieved.

Fixes #2611

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.034% when pulling 2816204 on parlough:fix/include-new-rules-in-machine-sets into 0a07c5f on dart-lang:master.

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pq
Copy link
Member

pq commented Jun 2, 2021

Thanks!

@pq pq merged commit 4d32508 into dart-lang:master Jun 2, 2021
@pq
Copy link
Member

pq commented Jun 2, 2021

I just re-generated and published fresh json contents. Let me know if you see any issues!

@parlough
Copy link
Member Author

parlough commented Jun 2, 2021

@pq Perfect thanks! I was just about to do the same. Looks great 🥳

@parlough parlough deleted the fix/include-new-rules-in-machine-sets branch June 2, 2021 00:12
@pq
Copy link
Member

pq commented Jun 2, 2021

Good deal. Thanks for tying up this loose end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include new rulesets in machine generated JSON once released
3 participants