Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime: please add 'text/x-markdown' for markdown file extensions (md, markdown) to the _defaultExtensionMap #389

Closed
DartBot opened this issue Jun 5, 2015 · 3 comments · Fixed by dart-lang/mime#85
Labels
package:mime type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#12857

This issue was originally filed by ross.dart....@gmail.com


0.6.21_r26639

As markdown is quite common these days, and this change does not conflict with anything currently in the _defaultExtensionMap, I think it is reasonable to add it?

'md':'text/x-markdown',
'markdown':'text/x-markdown',

The mime type 'text/x-markdown' seems to be what is most commonly used, for example:

node-mime: https://github.com/broofa/node-mime/pull/48/files
CodeMirror: http://codemirror.net/mode/markdown/

thanks!

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This comment was originally written by ross.dart...@gmail.com


hmm actually while you're in there (if you go in) can you also please add 'yaml'? I'm not sure what the appropriate mime type for it is, there seems to be less agreement for it...

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5449880?v=3" align="left" width="48" height="48"hspace="10"> Comment by iposva-google


Added Area-Pkg, Library-MIME, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/3276024?v=3" align="left" width="48" height="48"hspace="10"> Comment by anders-sandholm


Removed Library-MIME label.
Added Pkg-MIME label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:mime type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants