Add text/markdown mimeType lookup by extension
#85
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
literallylara
changed the title
text/x-markdown mimeType lookup by extensiontext/markdown mimeType lookup by extension
|
@devoncarew @natebosch – thoughts? |
| @@ -434,6 +434,8 @@ const Map<String, String> defaultExtensionMap = <String, String>{ | |||
| 'mc1': 'application/vnd.medcalcdata', | |||
| 'mcd': 'application/vnd.mcd', | |||
| 'mcurl': 'text/vnd.curl.mcurl', | |||
| // https://www.rfc-editor.org/rfc/rfc7763 | |||
There was a problem hiding this comment.
The RFC also mentions .markdown as an extension. Do we think that's unpopular enough now to not be worth supporting?
There was a problem hiding this comment.
Good catch! In 2014, one of the authors of Markdown actually endorsed .markdown as the only extension they would use. Either way, I think it makes sense to add for the sake of completeness. I'll prepare a commit.
Add `.md` and `.markdown` extensions.
Fixes dart-lang/tools#389
RFC: https://www.rfc-editor.org/rfc/rfc7763.html