Skip to content

Commit

Permalink
Remove JNI macos directory (#1122)
Browse files Browse the repository at this point in the history
Currently, macOS is not supported. Having this directory here breaks builds on apps that import jni and build macOS (among other platforms), even though if they don't need jni/jnigen for macOS specifically (and only use it on Android, for example).

Therefore, removing this directory should fix the issue for now before macOS support is actually added to the package.

```
macos/Classes/jni.c:3:10: fatal error: '../../src/jni.c' file not found
#include "../../src/jni.c"
         ^~~~~~~~~~~~~~~~~
```
  • Loading branch information
vaind committed May 6, 2024
1 parent 8ec4f77 commit 7060845
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 31 deletions.
4 changes: 4 additions & 0 deletions pkgs/jni/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.9.1-wip

- Fix compilation on macOS for consumers that don't use JNI on macOS (which is still not supported) ([#1122](https://github.com/dart-lang/native/pull/1122)).

## 0.9.0

- **Breaking Change**
Expand Down
3 changes: 0 additions & 3 deletions pkgs/jni/macos/Classes/jni.c

This file was deleted.

27 changes: 0 additions & 27 deletions pkgs/jni/macos/jni.podspec

This file was deleted.

2 changes: 1 addition & 1 deletion pkgs/jni/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

name: jni
description: A library to access JNI from Dart and Flutter that acts as a support library for package:jnigen.
version: 0.9.0
version: 0.9.1-wip
repository: https://github.com/dart-lang/native/tree/main/pkgs/jni

topics:
Expand Down

0 comments on commit 7060845

Please sign in to comment.