Remove JNI macos directory #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, macOS is not supported. Having this directory here breaks builds on apps that import jni and build macOS (among other platforms), even though if they don't need jni/jnigen for macOS specifically (and only use it on Android, for example).
Therefore, removing this directory should fix the issue for now before macOS support is actually added to the package.
```
macos/Classes/jni.c:3:10: fatal error: '../../src/jni.c' file not found
#include "../../src/jni.c"
^~~~~~~~~~~~~~~~~
```
PR HealthChangelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, macOS is not supported. Having this directory here breaks builds on apps that import jni and build macOS (among other platforms), even though if they don't need jni/jnigen for macOS specifically (and only use it on Android, for example).
Therefore, removing this directory should fix the issue for now before macOS support is actually added to the package.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.