-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete coverage.sh #1124
Delete coverage.sh #1124
Conversation
PR HealthCoverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
This reverts commit c103d2c.
Confirmed we have nice logs for test failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liamappelbe ! 🚀
@@ -7,6 +7,9 @@ | |||
// Objective C support is only available on mac. | |||
@TestOn('mac-os') | |||
|
|||
// This test is slightly flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document why it is flaky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Removed the duplicate test step from the workflows, which speeds things up. ffigen's mac tests (with all the mac-only ObjC tests, and with coverage) now run faster than the windows tests.
While I was there I fixed some flakiness in automated_ref_count_test
Fixes #1120