-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_cli] build_mode #50
Comments
@stuartmorgan How common is doing something different in (In the Dart ecosystem we haven't seen any use of debug/release yet. The Dart SDK itself is almost always release for our end users, and packages with FFI use only publish with release mode and only the package authors locally might build a debug mode. So in that case it can just be a const in the top level |
I don't have any metrics on this, but having assertions and/or logging that's only enabled in debug mode is not uncommon in general in native code. We have it in some our own plugins, for instance.
Plugin clients not getting debug logging from plugins they use would not be great. That kind of logging can be useful for figuring out that you are using the plugin wrong. |
https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html
https://doc.rust-lang.org/cargo/reference/profiles.html
https://cocoacasts.com/tips-and-tricks-managing-build-configurations-in-xocde Gradle has debug and release. https://developer.android.com/build/building-cmdline#DebugMode
I believe the Dart SDK is only available in release mode (unless built manually), and consequently so are
https://docs.flutter.dev/testing/build-modes We could make the config for We can always opt to open up to arbitrary build_mode names later, so let's start with a closed set. Proposed set:
Flutter |
I don't know how often (if ever) someone would have different behavior for |
It won't be breaking if we just make it opaque objects (like we have done with |
We should support a build mode (
debug
,release
) that can be passed in by the launcher (Flutter/DartSDK).CMake equivalent: build_type
Rust equivalent: profile
The text was updated successfully, but these errors were encountered: