Build mode #62
Merged
Build mode #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HosseinYousefi
approved these changes
Jun 7, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 8, 2023
Manual roll of: dart-lang/native#62 Bug: #50565 Change-Id: Ie5b9ef9e9cdfbb9c19eac299f9f0294496b77520 Cq-Include-Trybots: luci.dart.try:pkg-win-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-linux-release-try,pkg-linux-debug-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308040 Reviewed-by: Hossein Yousefi <yousefi@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
BuildModewithreleaseanddebugvalues.This is not an enum, but a collection with two opaque objects. (Similar to
Target.) This way adding more values later will not be a breaking change.BuildMode is required, this means that launchers will have to set it. (Currently, dart has no concept of build modes, we will have to default to
releasefor now and add some logic todart runanddart buildlater.) Since it is required, we will have to do a manual roll into the Dart SDK where we start passingBuildMode.releaseto the new required argument.Package c_compiler picks up the configuration and sets either the
DEBUGorRELEASEmacro to1.We should probably do the mapping from
BuildModeto defines inbuild.dartfiles, because it might be project specific. The defines should be added to theCBuilderconstructors orrunfunction. (Filed #61 to track this.)Bug: