Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version 0.13.16 leads build failed. #284

Closed
PonyCui opened this issue Sep 12, 2019 · 9 comments
Closed

The version 0.13.16 leads build failed. #284

PonyCui opened this issue Sep 12, 2019 · 9 comments
Assignees
Labels

Comments

@PonyCui
Copy link

PonyCui commented Sep 12, 2019

This is the build failed message.

    Compiler message:
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/builder_info.dart:43:34: Error: Method not found: 'MapFieldInfo.map'.
        _addField(MapFieldInfo<K, V>.map(name, tagNumber, index, PbFieldType.M,
                                     ^^^
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/field_info.dart:45:9: Error: '_mapEntryBuilderInfo' isn't an instance field of this class.
            _mapEntryBuilderInfo = null {
            ^^^^^^^^^^^^^^^^^^^^
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/field_info.dart:61:9: Error: '_mapEntryBuilderInfo' isn't an instance field of this class.
            _mapEntryBuilderInfo = null;
            ^^^^^^^^^^^^^^^^^^^^
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/field_info.dart:68:9: Error: '_mapEntryBuilderInfo' isn't an instance field of this class.
            _mapEntryBuilderInfo = null {
            ^^^^^^^^^^^^^^^^^^^^
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/field_info.dart:82:12: Error: '_mapEntryBuilderInfo' isn't an instance field of this class.
          this._mapEntryBuilderInfo])
               ^^^^^^^^^^^^^^^^^^^^
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/field_info.dart:199:9: Error: Superclass has no constructor named 'FieldInfo._'.
          : super._(
            ^^^^^
    file:///Users/jenkins/.pub-cache/hosted/pub.dartlang.org/protobuf-0.13.16/lib/src/protobuf/field_info.dart:195:21: Error: Final field '_mapEntryBuilderInfo' is not initialized.
    Try to initialize the field in the declaration or in every constructor.
      final BuilderInfo _mapEntryBuilderInfo;
@aaronlademann-wf
Copy link

aaronlademann-wf commented Sep 12, 2019

I can confirm that protobuf 0.13.16 is causing every build in our company's CI system to fail right now.

Appears to be related to #280

@nwparker @sigurdm @szakarias

@nwparker
Copy link
Contributor

nwparker commented Sep 12, 2019 via email

@jakemac53
Copy link
Contributor

jakemac53 commented Sep 12, 2019

The version needs to be rolled back (0.13.6) as it is a breaking change. The rollback should be published as 0.13.7 or 0.13.16+1.

cc @sigurdm

@kevmoo kevmoo added the bug label Sep 12, 2019
@kevmoo
Copy link
Collaborator

kevmoo commented Sep 12, 2019

We should do this ASAP. Much breaking. 😢

@jakemac53
Copy link
Contributor

Note that the workaround here is to pin protobuf to <0.13.6:

dependency_overrides:
  protobuf: <0.13.16

@jakemac53
Copy link
Contributor

We have now published bazel_worker version 0.1.22 which allows proto 0.14.x and should also resolve the issue if you pub upgrade (assuming you don't have other packages blocking the latest proto).

@jakemac53
Copy link
Contributor

I pushed a branch to do the revert https://github.com/dart-lang/protobuf/tree/revert-0.13.16.

This should be published and then merged into master.

@jakemac53
Copy link
Contributor

Ok actually I managed to get the keys from an owner and publish on my own. I sent out the PR to merge the changelog entry into master #287. I also tagged the release in the repo.

@sigurdm
Copy link
Collaborator

sigurdm commented Sep 13, 2019

Sorry - i published 0.13.16 from the wrong commit.
Thanks @jakemac53 for publishing a revert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants