Fix dummy fields #270
Merged
Fix dummy fields #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
force-pushed
the
fix_dummy_fields
branch
from
5eecd9c
to
8fd88fb
Compare
sigurdm
force-pushed
the
fix_dummy_fields
branch
from
8fd88fb
to
950da2d
Compare
szakarias
approved these changes
Aug 12, 2019
protobuf/test/dummy_field_test.dart
Outdated
|
|
||
| main() { | ||
| test('Has no known fields', () { | ||
| expect(Message(), Message()); |
|
This change has broken the world, see: #284 Curious why it was published well after being merged and even after later changes? |
So sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FieldInfo object created be the treeshaker before would trigger assertions.