Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests to /search without a 'q' parameter results in 'Internal Server Error' response #13

Closed
sgjesse opened this issue May 5, 2015 · 1 comment
Closed

Requests to /search without a 'q' parameter results in 'Internal Server Error' response #13

sgjesse opened this issue May 5, 2015 · 1 comment

Comments

@sgjesse
Copy link
Contributor

sgjesse commented May 5, 2015

Requests like this:

https://pub.dartlang.org/search
https://pub.dartlang.org/search?
https://pub.dartlang.org/search?x=
@mkustermann
Copy link
Member

CL is up for review https://codereview.chromium.org/1128833002/

mkustermann added a commit that referenced this issue May 6, 2015
@mkustermann
Align /search endpoint to python version
48fe765 
This makes:
  - /search
  - /search?q
  - /search?q=
assume the empty search string.

In case no results were found, a corresponding message will now be displayed.

[The python version considers /search alone - without the `q` query parameter as
404 not found - we deviate in this case]

BUG=#13
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1128833002
@kevmoo kevmoo mentioned this issue Jul 19, 2017
Closed
@kevmoo kevmoo mentioned this issue Aug 3, 2017
Closed
@bobzhou80 bobzhou80 mentioned this issue Mar 21, 2019
Closed
@rmazur rmazur mentioned this issue Feb 14, 2020
Closed
@bsutton bsutton mentioned this issue Mar 14, 2021
Closed
@yosahil32 yosahil32 mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgjesse @mkustermann