Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error 'Internal server error' for 404 responses #4

Closed
sgjesse opened this issue Apr 20, 2015 · 1 comment
Closed

Error 'Internal server error' for 404 responses #4

sgjesse opened this issue Apr 20, 2015 · 1 comment

Comments

@sgjesse
Copy link
Contributor

sgjesse commented Apr 20, 2015

The request for e.g. /xxx returns 'Internal server error instead of the 404 page.
@sgjesse sgjesse mentioned this issue Apr 20, 2015
Closed
sgjesse added a commit that referenced this issue Apr 20, 2015
@sgjesse
Fix a number of 'Internal server error's
1e3ed80 
This ensures that 'appHandler' always return Future<shelf.Response>. This
is expected by the caller which has a .catchError on the return value.

The following messages where logged to stderr by the application:

bin/server.dart 96:64  main.<fn>.<async>.<fn>.<async>.<fn>.<async>.<fn>.<fn>.<fn>.<async>
Error thrown by handler.
dart:core              Object.noSuchMethod
Arguments: [Closure: (dynamic, dynamic) => dynamic]
Receiver: Instance of 'Response'
NoSuchMethodError: method not found: 'catchError'

Class 'Response' has no instance method 'catchError'.
ERROR - 2015-04-20 12:45:29.067

Prepare version for new release

R=wibling@google.com

BUG=#4
BUG=#5

Review URL: https://codereview.chromium.org/1094123002
@sgjesse
Copy link
Contributor Author

sgjesse commented Apr 21, 2015

Fixed in 1e3ed80

@sgjesse sgjesse closed this as completed Apr 21, 2015
@kevmoo kevmoo mentioned this issue Jul 19, 2017
Closed
@kevmoo kevmoo mentioned this issue Aug 3, 2017
Closed
@Arunva28 Arunva28 mentioned this issue May 6, 2018
Closed
@bobzhou80 bobzhou80 mentioned this issue Mar 21, 2019
Closed
@rmazur rmazur mentioned this issue Feb 14, 2020
Closed
@bsutton bsutton mentioned this issue Mar 14, 2021
Closed
@yosahil32 yosahil32 mentioned this issue Mar 15, 2021
Closed
@shirvanie shirvanie mentioned this issue Nov 13, 2023
Closed
@chunlee-thong chunlee-thong mentioned this issue Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgjesse