New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account menu on the top bar. #2368

Merged

isoos merged 1 commit into dart-lang:master from isoos:login-menu

Jun 17, 2019

Collaborator

isoos commented Jun 14, 2019

Part of #2316, still behind the experimental cookie.

removed the Google sign-in button, and with that:
- need to call goog.auth2.init([options]).then(initCallback)
- need to call signIn() when triggered
removed the prior status bar, and using the same hover+dropdown that the nav menu is using
added some minimal DOM helper methods to build and update the DOM

A few unresolved parts for later PRs:

hoverable dropdown positioned to the right
profile picture is not entirely centered vertically
not sure if every google account has a profile image, and what happens then
mobile menu is still broken with this one


          Account menu on the top bar.

737aac3

isoos requested a review from jonasfj

June 14, 2019 17:25

googlebot added the cla: yes label

jonasfj approved these changes

View reviewed changes

isoos merged commit 26a366e into dart-lang:master

isoos deleted the login-menu branch

June 17, 2019 10:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels