Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate pub command #2736

Closed
7 of 8 tasks
jonasfj opened this issue Nov 9, 2020 · 5 comments
Closed
7 of 8 tasks

deprecate pub command #2736

jonasfj opened this issue Nov 9, 2020 · 5 comments

Comments

@jonasfj
Copy link
Member

jonasfj commented Nov 9, 2020

Things to do:

@sigurdm sigurdm changed the title deprecated pub command deprecate pub command Nov 10, 2020
@sigurdm
Copy link
Contributor

sigurdm commented Nov 10, 2020

Migrate flutter pub to not wrap pub, but dart pub instead.

We probably want to wrap dart --disable-dartdev-analytics pub instead, so we don't send analytics twice.

@sigurdm
Copy link
Contributor

sigurdm commented Mar 23, 2021

Migrate travis-ci scripts to use dart pub get (for dart >= 2.10.0)

Do we still need this after migrating to github code actions?

@jonasfj
Copy link
Member Author

jonasfj commented Apr 19, 2021

note to self, patching travis involves:

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Aug 24, 2021
Also makes the `pub` shell script (and its .bat counterpart)
forward to a `dart __deprecated_pub` command that implements the
old top-level.

This allows us to get rid of pub.dart.snapshot saving ~15 MB in a
unzipped sdk.

The reason for not forwarding directly to `dart pub` is that the
interface is slightly different (for example there is no `dart pub --version`).


The only new commit in pub is: `3c2ce330 Expose toplevel as a command`


Bug: dart-lang/pub#2736
Change-Id: I6eb08d120c4844b3a12bc29544df6a868cd6fcc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210582
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
@mit-mit
Copy link
Member

mit-mit commented Aug 24, 2021

@sigurdm can this be closed now?

@sigurdm
Copy link
Contributor

sigurdm commented Aug 24, 2021

I managed to commit out of order - we can close whenever: flutter/flutter#88509 lands. I hope to land it before flutter discovers that the sdk is broken for them :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants