New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`pub global run` ruins binstubs. #4206

Closed

sigurdm opened this issue Apr 4, 2024 · 1 comment

Labels

type-bug

Contributor

sigurdm commented Apr 4, 2024

When updating the binstub we use the "dummy" package name instead of the activated package name

Reported by @kevmoo

Contributor Author

sigurdm commented Apr 4, 2024

Fixed in #4205

sigurdm added the type-bug label

sigurdm closed this as completed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue


          Bump pub to f3b1199fcab37a197f2980bf6b28e421e7bce771

1074cda

Changes:
```
> git log --format="%C(auto) %h %s" 3f0df78..f3b1199
 https://dart.googlesource.com/pub.git/+/f3b1199f Fix package name when refreshing binstubs (4205)
 https://dart.googlesource.com/pub.git/+/09b98913 Update package:frontend_server_client constraint to ^4.0.0 (4202)
 https://dart.googlesource.com/pub.git/+/1cf6f77c Bump actions/checkout from 4.1.1 to 4.1.2 (4204)
 https://dart.googlesource.com/pub.git/+/64ca1ba2 Teach `pub deps` to show deps of all workspace packages (4198)

```

Diff: https://dart.googlesource.com/pub.git/+/3f0df78417f7c112b933fbcdc1c5c87bde680cb1..f3b1199fcab37a197f2980bf6b28e421e7bce771/
Bug: dart-lang/pub#4206
Change-Id: I5c509240f4350536078dfd7f66344d9327a040c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361061
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Sarah Zakarias <zarah@google.com>

sigurdm mentioned this issue

[CP] Fix package name when refreshing binstubs dart-lang/sdk#55373

Closed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue


          [beta] Bump pub to ed20b45589766d6fd135e93460b9e8255ccba519

b593783

Changes:
```
> git log --format="%C(auto) %h %s" 3f0df78..ed20b45
 https://dart.googlesource.com/pub.git/+/ed20b455 Fix package name when refreshing binstubs (4205)

```

Diff: https://dart.googlesource.com/pub.git/+/3f0df78417f7c112b933fbcdc1c5c87bde680cb1..ed20b45589766d6fd135e93460b9e8255ccba519/
Bug: dart-lang/pub#4206
Change-Id: I9c46f08f46b159d864a4b72c08673fe5f20d8886
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/361061
Cherry-pick-request: #55373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361102
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment