Fix package name when refreshing binstubs #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Apr 4, 2024
jonasfj
reviewed
Apr 4, 2024
| /// [Entrypoint.workspaceRoot]. | ||
| Package activatedPackage(Entrypoint entrypoint) { | ||
| if (entrypoint.isCachedGlobal) { | ||
| final dep = entrypoint.workspaceRoot.dependencies.keys.single; |
There was a problem hiding this comment.
Might be worth explaining how we create a dummy package.
sigurdm
added a commit
that referenced
this pull request
Apr 4, 2024
sigurdm
added a commit
that referenced
this pull request
Apr 5, 2024
Merge cherry pick of "Fix package name when refreshing binstubs" (#4205)
gspencergoog
added a commit
to gspencergoog/pub
that referenced
this pull request
May 1, 2024
This reverts commit ed20b45.
gspencergoog
added a commit
to gspencergoog/pub
that referenced
this pull request
May 1, 2024
This reverts commit ed20b45.
1 task
jakemac53
pushed a commit
that referenced
this pull request
May 1, 2024
sigurdm
added a commit
to sigurdm/pub
that referenced
this pull request
May 7, 2024
…art-lang#4255) This reverts commit 4a44cfb.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By mistake we were using the name of the dummy-package "pub global activate" instead of the activated package.