Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly close stdin for child processes. #1485

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Properly close stdin for child processes. #1485

merged 1 commit into from
Dec 7, 2016

Conversation

nex3
Copy link
Member

@nex3 nex3 commented Dec 6, 2016 •
edited
Loading

Closes #1482.

kevmoo
kevmoo approved these changes Dec 7, 2016
View reviewed changes
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoechi
Copy link

zoechi commented Dec 7, 2016

Should be dart-lang/sdk#25348

@nex3
Copy link
Member Author

nex3 commented Dec 7, 2016

Thanks @zoechi, I'll update it.

@nex3 nex3 merged commit 5577fa6 into master Dec 7, 2016
@nex3 nex3 deleted the stdin branch December 7, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@munificent munificent munificent approved these changes

Assignees

@munificent munificent

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nex3 @zoechi @kevmoo @munificent @googlebot