Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix package name when refreshing binstubs (#4205)" #4255

Merged
merged 1 commit into from
May 1, 2024

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented May 1, 2024

This reverts commit ed20b45 (#4205) because it is causing the Flutter build to fail with concurrency issues. See flutter/flutter#147609

@sigurdm

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this is a high priority revert.

@jonasfj @sigurdm should take a closer look when they have a chance

@jakemac53 jakemac53 merged commit 4a44cfb into dart-lang:master May 1, 2024
23 checks passed
@jonasfj
Copy link
Member

jonasfj commented May 2, 2024

@sigurdm we didn't cherry pick this, right?

@sigurdm
Copy link
Contributor

sigurdm commented May 2, 2024

Yeah it is trying to fix something that landed after 3.4.0-beta.

sigurdm added a commit to sigurdm/pub that referenced this pull request May 7, 2024
@sigurdm sigurdm mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants