Parsing option: lenient. #36
Conversation
| @@ -116,9 +116,30 @@ class Pubspec { | |||
| } | |||
| } | |||
|
|
|||
| factory Pubspec.fromJson(Map json) => _$PubspecFromJson(json); | |||
| factory Pubspec.fromJson(Map json, {bool lenient = false}) { | |||
There was a problem hiding this comment.
Isn't permissive a better way to write it?
There was a problem hiding this comment.
Dart SDK doesn't have either, and Java's date parsing uses lenient.
There was a problem hiding this comment.
Also shouldn't this be the default mode?
There was a problem hiding this comment.
I think defaulting to strict mode is better. (e.g. being explicit that we don't need strict checks).
| @@ -116,9 +116,31 @@ class Pubspec { | |||
| } | |||
| } | |||
|
|
|||
| factory Pubspec.fromJson(Map json) => _$PubspecFromJson(json); | |||
| factory Pubspec.fromJson(Map json, {bool lenient = false}) { | |||
There was a problem hiding this comment.
Please add a doc comment describing what lenient does.
|
Do we still need this parsing mode if we get rid of the broken package on pub? |
We may not need it right now (assumed that package will be removed), but I'd rather use lenient parsing on the read-access part of the pub site. While we would remember this incident for a few more months, it could be well forgotten in a year or so, and the next similar incident could cause similar issues. Having said that, it may be worth to add logging to |
I would, but I have no permission to do so, please do the merge for me. |
A bit of alternative to @jonasfj's per-property parsing: instead of parsing it on per-property, we remove the top-level key on each reporter error.
This does not yet delegate the lenient flag to embedded classes like
Dependency(and I'm not sure if it is feasible to without eitherjson_serializablesupport or using zones).