Skip to content

Commit

Permalink
[nnbd_migration] Remove TODO now that do-while is more supported
Browse files Browse the repository at this point in the history
Change-Id: Idfaa290290954d6b4bdf131a26f760b85c7e4312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112649
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
  • Loading branch information
MichaelRFairhurst authored and commit-bot@chromium.org committed Aug 12, 2019
1 parent 721ff35 commit 2659262
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions pkg/nnbd_migration/test/edge_builder_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2568,9 +2568,8 @@ void test(bool b, C c) {
}
''');

// TODO(mfairhurst): enable this check
//assertNullCheck(checkExpression('b/*check*/'),
// assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: false));
assertNullCheck(checkExpression('b/*check*/'),
assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: false));
assertNullCheck(checkExpression('c.m'),
assertEdge(decoratedTypeAnnotation('C c').node, never, hard: false));
}
Expand All @@ -2591,9 +2590,8 @@ void test(bool b, C c1, C c2) {
}
''');

// TODO(mfairhurst): enable this check
//assertNullCheck(checkExpression('b/*check*/'),
// assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: true));
assertNullCheck(checkExpression('b/*check*/'),
assertEdge(decoratedTypeAnnotation('bool b').node, never, hard: true));
assertNullCheck(checkExpression('c1.m'),
assertEdge(decoratedTypeAnnotation('C c1').node, never, hard: true));
assertNullCheck(checkExpression('c2.m'),
Expand Down

0 comments on commit 2659262

Please sign in to comment.