-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Split CanonicalNameError, no warning if CanonicalNameSdkError
Prior to this CL, we would issue a warning whenever a CanonicalNameError was encountered. This is in principal a good thing, but because we currently have no way to detect if the sdk we get is the one we expect (by any other measure than when it issues a CanonicalNameError) we often issue these warnings for no "real reason" whenever, for instance, the flutter sdk changes. This CL splits the CanonicalNameError in two such that errors with references to the sdk ("dart:" libraries) issue CanonicalNameSdkError instead, an we then handle that differently. Namely we silently ignore the error (i.e. don't issue a warning) and just don't initialize from dill. This should remedy the situation and be strictly better than to always swallow CanonicalNameErrors. Bug: 36032 Change-Id: Idbae0b5ee5b9843a5dbeb49b3c65ae25f5962e36 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105240 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Kevin Millikin <kmillikin@google.com>
- Loading branch information
Showing
3 changed files
with
103 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters