Skip to content

Commit

Permalink
Check for SDK error regressions on presubmit
Browse files Browse the repository at this point in the history
This is to keep us from inadvertently regressing the SDK.  See related bug #103

R=leafp@google.com

Review URL: https://codereview.chromium.org/1154213008
  • Loading branch information
vsmenon committed May 28, 2015
1 parent 9e5896f commit 8e11888
Show file tree
Hide file tree
Showing 2 changed files with 1,213 additions and 2 deletions.
12 changes: 10 additions & 2 deletions pkg/dev_compiler/tool/build_sdk.sh
Expand Up @@ -13,8 +13,16 @@ if [[ -d lib/runtime/dart ]] ; then
fi

# TODO(jmesserly): for now we're suppressing errors in SDK compilation
dart -c bin/devc.dart --no-source-maps --sdk-check --force-compile -l shout \
--dart-sdk test/generated_sdk -o lib/runtime/ dart:core || true
dart -c bin/devc.dart --no-source-maps --sdk-check --force-compile -l warning \
--dart-sdk test/generated_sdk -o lib/runtime/ dart:core \
> test/generated_sdk/sdk_errors.txt || true

if ! diff tool/sdk_expected_errors.txt test/generated_sdk/sdk_errors.txt ; then
echo
echo 'SDK errors have changed. To update expectations, run:'
echo '$ cp test/generated_sdk/sdk_errors.txt tool/sdk_expected_errors.txt'
exit 1
fi

if [[ ! -f lib/runtime/dart/core.js ]] ; then
echo 'core.js not found, assuming build failed.'
Expand Down

0 comments on commit 8e11888

Please sign in to comment.