Parse YieldStatement with Fasta.

R=paulberry@google.com BUG= Review-Url: https://codereview.chromium.org/2769133004 .
dart-lang · Mar 24, 2017 · 9b6c63a · 9b6c63a
1 parent 0842fb4
commit 9b6c63a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 20 deletions.
diff --git a/pkg/analyzer/lib/src/fasta/ast_builder.dart b/pkg/analyzer/lib/src/fasta/ast_builder.dart
@@ -438,6 +438,15 @@ class AstBuilder extends ScopeListener {
         body));
   }
 
+  @override
+  void endYieldStatement(Token yieldToken, Token starToken, Token endToken) {
+    debugEvent("YieldStatement");
+    assert(endToken.lexeme == ';');
+    Expression expression = pop();
+    push(ast.yieldStatement(toAnalyzerToken(yieldToken),
+        toAnalyzerToken(starToken), expression, toAnalyzerToken(endToken)));
+  }
+
   @override
   void handleNoVariableInitializer(Token token) {
     debugEvent("NoVariableInitializer");

diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -1087,12 +1087,6 @@ class StatementParserTest_Fasta extends FastaParserTestCase
     super.test_parseContinueStatement_noLabel();
   }
 
-  @override
-  @failingTest
-  void test_parseForStatement_each_await() {
-    super.test_parseForStatement_each_await();
-  }
-
   @override
   @failingTest
   void test_parseForStatement_each_noType_metadata() {
@@ -1215,18 +1209,6 @@ class StatementParserTest_Fasta extends FastaParserTestCase
   void test_parseTryStatement_on_catch_finally() {
     super.test_parseTryStatement_on_catch_finally();
   }
-
-  @override
-  @failingTest
-  void test_parseYieldStatement_each() {
-    super.test_parseYieldStatement_each();
-  }
-
-  @override
-  @failingTest
-  void test_parseYieldStatement_normal() {
-    super.test_parseYieldStatement_normal();
-  }
 }
 
 /**

diff --git a/pkg/analyzer/test/generated/parser_test.dart b/pkg/analyzer/test/generated/parser_test.dart
@@ -12990,7 +12990,7 @@ abstract class StatementParserTestMixin implements AbstractParserTestCase {
 
   Statement _parseAsyncStatement(String code, {bool isGenerator: false}) {
     var star = isGenerator ? '*' : '';
-    var localFunction = parseStatement('wrapper() async$star { $code };')
+    var localFunction = parseStatement('wrapper() async$star { $code }')
         as FunctionDeclarationStatement;
     var localBody = localFunction.functionDeclaration.functionExpression.body
         as BlockFunctionBody;

diff --git a/pkg/front_end/test/fasta/kompile.status b/pkg/front_end/test/fasta/kompile.status
@@ -24,7 +24,7 @@ map: Fail
 mixin: Crash
 operators: Crash
 redirecting_constructor: Fail
-statements: Crash
+statements: Fail
 super_rasta_copy: Crash
 top_level_accessors: Crash
 type_variable_as_super: Fail