Skip to content

Commit

Permalink
[cfe] Allow expression compilation with constant-update-2018
Browse files Browse the repository at this point in the history
Allow expressions to be compiled by the VM but without evaluating
constants.  This will use the VM's C++ constant evaluator.

Fixes #36479

Change-Id: Icd6e769e53db5d211a083d1f5cff7ddf88cc4da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98675
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
  • Loading branch information
Kevin Millikin authored and commit-bot@chromium.org committed Apr 10, 2019
1 parent 5ed4cda commit ac02811
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ import '../messages.dart'
templateMissingImplementationCause,
templateSuperclassHasNoDefaultConstructor;

import '../problems.dart' show unhandled, unimplemented;
import '../problems.dart' show unhandled;

import '../scope.dart' show AmbiguousBuilder;

Expand Down Expand Up @@ -790,10 +790,6 @@ class KernelTarget extends TargetImplementation {
}

void runProcedureTransformations(Procedure procedure) {
if (loader.target.enableConstantUpdate2018) {
unimplemented('constant evaluation during expression evaluation',
procedure.fileOffset, procedure.fileUri);
}
backendTarget.performTransformationsOnProcedure(
loader.coreTypes, loader.hierarchy, procedure,
logger: (String msg) => ticker.logMs(msg));
Expand Down

0 comments on commit ac02811

Please sign in to comment.