Prepare to publish analyzer 3.4.1 and _fe_analyzer_shared 38.0.0

Bug: #48658
Change-Id: I1d3d531cf3550a657a1cdd9d7a29467e4c92df0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

pkg/_fe_analyzer_shared/pubspec.yaml

@@ -1,5 +1,5 @@
 name: _fe_analyzer_shared
-version: 37.0.0
+version: 38.0.0
 description: Logic that is shared between the front_end and analyzer packages.
 homepage: https://github.com/dart-lang/sdk/tree/master/pkg/_fe_analyzer_shared
 

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.4.1
+* Remove checks for consistency after operations in `AnalysisSession`.
+
 ## 3.4.0
 * Deprecated `Resource.parent2`, use `parent` instead.
 * Deprecated `astFactory`, clients should not create AST nodes manually.

pkg/analyzer/lib/src/dart/analysis/session.dart

@@ -57,33 +57,25 @@ class AnalysisSessionImpl implements AnalysisSession {
   @override
   Future<SomeErrorsResult> getErrors(String path) async {
     _checkConsistency();
-    var result = await _driver.getErrors(path);
-    _checkConsistency();
-    return result;
+    return await _driver.getErrors(path);
   }
 
   @override
   SomeFileResult getFile(String path) {
     _checkConsistency();
-    var result = _driver.getFileSync(path);
-    _checkConsistency();
-    return result;
+    return _driver.getFileSync(path);
   }
 
   @override
   Future<SomeLibraryElementResult> getLibraryByUri(String uri) async {
     _checkConsistency();
-    var result = await _driver.getLibraryByUri(uri);
-    _checkConsistency();
-    return result;
+    return await _driver.getLibraryByUri(uri);
   }
 
   @override
   SomeParsedLibraryResult getParsedLibrary(String path) {
     _checkConsistency();
-    var result = _driver.getParsedLibrary(path);
-    _checkConsistency();
-    return result;
+    return _driver.getParsedLibrary(path);
   }
 
   @override
@@ -94,25 +86,19 @@ class AnalysisSessionImpl implements AnalysisSession {
       return NotElementOfThisSessionResult();
     }
 
-    var result = _driver.getParsedLibraryByUri(element.source.uri);
-    _checkConsistency();
-    return result;
+    return _driver.getParsedLibraryByUri(element.source.uri);
   }
 
   @override
   SomeParsedUnitResult getParsedUnit(String path) {
     _checkConsistency();
-    var result = _driver.parseFileSync(path);
-    _checkConsistency();
-    return result;
+    return _driver.parseFileSync(path);
   }
 
   @override
   Future<SomeResolvedLibraryResult> getResolvedLibrary(String path) async {
     _checkConsistency();
-    var result = await _driver.getResolvedLibrary(path);
-    _checkConsistency();
-    return result;
+    return await _driver.getResolvedLibrary(path);
   }
 
   @override
@@ -125,25 +111,19 @@ class AnalysisSessionImpl implements AnalysisSession {
       return NotElementOfThisSessionResult();
     }
 
-    var result = await _driver.getResolvedLibraryByUri(element.source.uri);
-    _checkConsistency();
-    return result;
+    return await _driver.getResolvedLibraryByUri(element.source.uri);
   }
 
   @override
   Future<SomeResolvedUnitResult> getResolvedUnit(String path) async {
     _checkConsistency();
-    var result = await _driver.getResult(path);
-    _checkConsistency();
-    return result;
+    return await _driver.getResult(path);
   }
 
   @override
   Future<SomeUnitElementResult> getUnitElement(String path) {
     _checkConsistency();
-    var result = _driver.getUnitElement(path);
-    _checkConsistency();
-    return result;
+    return _driver.getUnitElement(path);
   }
 
   /// Check to see that results from this session will be consistent, and throw

pkg/analyzer/pubspec.yaml

@@ -1,13 +1,13 @@
 name: analyzer
-version: 3.4.0
+version: 3.4.1
 description: This package provides a library that performs static analysis of Dart code.
 homepage: https://github.com/dart-lang/sdk/tree/main/pkg/analyzer
 
 environment:
   sdk: '>=2.14.0 <3.0.0'
 
 dependencies:
-  _fe_analyzer_shared: ^37.0.0
+  _fe_analyzer_shared: ^38.0.0
   collection: ^1.15.0
   convert: ^3.0.0
   crypto: ^3.0.0