Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/test.dart test script is too slow #1009

Closed
whesse opened this issue Dec 30, 2011 · 1 comment
Closed

tools/test.dart test script is too slow #1009

whesse opened this issue Dec 30, 2011 · 1 comment
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@whesse
Copy link
Contributor

whesse commented Dec 30, 2011

The dart port of the test script takes more than 4 minutes to reach 99%, compared to 2 minutes for test.py. We should eliminate this difference. I'm measuring time to 99% due to some tests that timeout at the end.

When listing the tests only, we see that most of the time is spent generating multitests:
test.py --list: 3 seconds
test.dart --list: 2 minutes 30 seconds
test.dart --list (with multitests disabled): 16 seconds.

Disabling multitests makes the test.dart script take only 2 minutes 18 seconds for a full run, so the major performance problem can be solved by fixing this one issue.

@whesse
Copy link
Contributor Author

whesse commented Dec 30, 2011

Processing the multitests and making the output tests takes only 2 seconds, so it is creating the directories and writing the files that takes the extra 2 minutes 15 seconds.

Just creating the files takes 1 minute more time than doing nothing.
So opening, writing, and closing is taking 1:15 more.

Changing the creation of the multitests to use synchronous file access speeds this up
tremendously. Listing now takes 25 seconds, and the entire test script now takes 2:20, versus 2:00 for test.py. The issue can be closed, though there may be other minor improvements possible.

The fix is now out for review, and will be committed.


Added Fixed label.

@whesse whesse added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Dec 30, 2011
@whesse whesse self-assigned this Dec 30, 2011
copybara-service bot pushed a commit that referenced this issue Aug 28, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`.

http (https://github.com/dart-lang/http/compare/631d4ec..cad7d60):
  cad7d60  2023-08-26  Alex James  Add response status code test (#1009)
  5ac7cfe  2023-08-24  Alex James  JavaClient stream response body using byte arrays (#1007)
  0e6e58a  2023-08-23  Brian Quinlan  Don't check the formatting of `ffigen`ed code (#1010)

markdown (https://github.com/dart-lang/markdown/compare/faabb1a..56e75df):
  56e75df  2023-08-26  Parker Lougheed  Standardize CommonMark spec links to https and v0.30 (#553)

mockito (https://github.com/dart-lang/mockito/compare/70aabfc..f5abf11):
  f5abf11  2023-08-28  Nate Bosch  Add a best practice sentence about data models

tools (https://github.com/dart-lang/tools/compare/e5ce42a..b72fae8):
  b72fae8  2023-08-24  Danny Tuppeny  Export Survey in package:unified_analytics (#151)

Change-Id: Id09f2300d3132a101dfaf84d9dc475ba92590aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

1 participant