Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated JavaScript for polymer elements dosn't call xxxChanged for published attributes #15080

Closed
DartBot opened this issue Nov 15, 2013 · 19 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-duplicate Closed in favor of an existing report

Comments

@DartBot
Copy link

DartBot commented Nov 15, 2013

This issue was originally filed by @zoechi


What steps will reproduce the problem?
1.
We run into this problem
https://code.google.com/p/dart/issues/detail?id=15038
when porting

  • https://github.com/ErikGrimes/polymer_elements
  • https://github.com/ErikGrimes/polymer_ui_elements
    which have a demo page for each polymer element in the 'example' directory.
    So we changed the package layout as suggested:
    We created a new package and symlinked the demo pages from example
    to the new packages web directory
    removed the transformers settings in polymer_elements/polymer_ui_elements
    and added them to the pubspec.yaml of the new package.
    2.
    pub build works fine
    But in all JS demo pages the xxxChanged methods for published attributes never get called (except when called from other methods directly)
    Methods like enteredView or ready are called though.

3.
No warning or error is shown (build/execution)

What is the expected output? What do you see instead?
Should work in JS as in Dart

What version of the product are you using? On what operating system?
Dart VM version: 1.0.0.3_r30187 (Tue Nov 12 00:09:52 2013) on "linux_x64"

Please provide any additional information below.
Before we changed the package structure as described above some examples worked fine in JS (those that were not affected by the issue linked above)
I also tried copying the files to the new package instead of symlinking but the problem persisted.

@sethladd
Copy link
Contributor

Added Area-Polymer, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Nov 27, 2013

This comment was originally written by @zoechi


When I add
transformers:

  • polymer:
        entry_points:
    (without any actual entry_points defined) to pubspec.yaml of the component package
    the generated JS works even when the package isn't supposed to have a polymer transformer specified.

Dart VM version: 1.0.1.3_r30657 (Mon Nov 25 18:29:39 2013) on "linux_x64"

@sigmundch
Copy link
Member

Added Library-PolymerBuild label.

@DartBot
Copy link
Author

DartBot commented May 3, 2014

This comment was originally written by @zoechi


I think this is related to 18489

@sigmundch
Copy link
Member

Added this to the 1.5 milestone.

@jmesserly
Copy link

Added Pkg-Polymer label.

@jmesserly
Copy link

Removed Pkg-Polymer label.
Added Pkg-PolymerBuild label.

@jmesserly
Copy link

Removed Library-PolymerBuild label.

@jmesserly
Copy link

Removed Area-Polymer label.
Added Area-Pkg label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Postponing to 1.6. Feel free to change this back (and give it a proper priority).


Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 4, 2014

This comment was originally written by @zoechi


I still had this a while ago (when I added the comment at May 3) but this seems not to be an issue on all projects. Maybe this is only when the project has Polymer elements in lib and also uses elements imported from another package.

I didn't have this in other projects and this is the only notable distinction.

@sigmundch
Copy link
Member

Thanks for the details!

I forgot to mention earlier, but I agree with you in #­4 that this will likely be fixed by issue #9.


Marked this as being blocked by #18489.

@sigmundch
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

merging with issue #20267 to track things together.


Added Duplicate label.
Marked as being merged into #20267.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#369.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-duplicate Closed in favor of an existing report
Projects
None yet
Development

No branches or pull requests

5 participants