Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args: Merge allowedHelp into allowed #15705

Closed
DartBot opened this issue Dec 18, 2013 · 4 comments
Closed

args: Merge allowedHelp into allowed #15705

DartBot opened this issue Dec 18, 2013 · 4 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request

Comments

@DartBot
Copy link

DartBot commented Dec 18, 2013

This issue was originally filed by @seaneagan


Currently it looks something like:

  var allowed = {
    'x': 'x help',
    'y': 'y help',
    'z': 'z help',
  }

  parser.addOption('foo', allowed: allowed.keys.toList(), allowedHelp: allowed);

Nicer would be:

  parser.addOption('foo', allowed: {
    'x': 'x help',
    'y': 'y help',
    'z': 'z help',
  });

So allowed: would allow Iterable<String> or Map<String, String>

@floitschG
Copy link
Contributor

Added Area-Pkg, Triaged labels.

@sethladd
Copy link
Contributor

I wonder if the team would be open to a patch for this?


Removed Priority-Unassigned label.
Added Priority-Low, Pkg-Args labels.

@srawlins
Copy link
Member

srawlins commented Oct 7, 2014

In order to make this a not breaking change, we could derive allowedHelp from allowed if allowed is a Map, but otherwise still accept an allowed List, and an allowedHelp.

@DartBot DartBot added Type-Defect P3 A lower priority bug or feature request area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Oct 7, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/args#25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

5 participants